Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds filtering and switches to iterative traversal #5588

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: adds filtering and switches to iterative traversal #5588

merged 1 commit into from
Nov 21, 2023
+56 −57

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Nov 14, 2023 •
edited by manusa
Loading

Description

closes #5584

It doesn't seem like we need traversal below java. classes as we're only looking for our annotations. Also we can switch to an iterative traversal, which should be less likely to blow out.

cc @andreaTP

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

andreaTP
andreaTP approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for sorting this out @shawkins !
I'm happy with your implementation as it looks more robust than before.

...r/api/src/main/java/io/fabric8/crd/generator/visitor/AnnotatedMultiPropertyPathDetector.java Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.5% 92.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@bequinn-hubspot bequinn-hubspot mentioned this pull request Nov 20, 2023
Closed
@manusa manusa added this to the 6.10.0 milestone Nov 21, 2023
@manusa manusa merged commit f6e728c into fabric8io:main Nov 21, 2023
19 of 20 checks passed
bequinn-hubspot added a commit to HubSpot/kubernetes-client that referenced this pull request Nov 28, 2023
@bequinn-hubspot
Backport fabric8io#5588 commit f54242d
fa3bacf
bequinn-hubspot added a commit to HubSpot/kubernetes-client that referenced this pull request Dec 1, 2023
@bequinn-hubspot
Backport fabric8io#5588 commit f54242d
e40db77
bequinn-hubspot added a commit to HubSpot/kubernetes-client that referenced this pull request Dec 1, 2023
@bequinn-hubspot
Backport fabric8io#5588 commit f54242d
2ed09ac
bequinn-hubspot added a commit to HubSpot/kubernetes-client that referenced this pull request Dec 1, 2023
@bequinn-hubspot
Backport fabric8io#5588 commit f54242d
4030ebc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.10.0
Development

Successfully merging this pull request may close these issues.

CRD Generator -- Stack overflow when using EnumMap type in Spec
4 participants
@shawkins @manusa @andreaTP @rohanKanojia